Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding -n to replace -d #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

n0tthetree
Copy link

-d is nonfunctional (defaults to True AND toggles to True when passed in CLI)
adding -n to archieve the wanted toggle-functionality

@SathyaBhat
Copy link
Owner

I think instead of adding another new flag we could just fix the existing one

@n0tthetree
Copy link
Author

Sure thing, I just didnt want to destroy any scripts someone has made on the assumption that it downloads both with and without the flag given...
Thats why I wanted an opt-out for the download function.

@n0tthetree
Copy link
Author

If you want -d to work as an opt-in to downloading, tell me and I'm just remove default=True in the definition and send a new merge req.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants